Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected defaultTimestamp value in RestJsonClientIgnoresDefaultValuesIfMemberValuesArePresentInResponse #2341

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

ysaito1001
Copy link
Contributor

This PR updates the expected defaultTimestamp to 2 in RestJsonClientIgnoresDefaultValuesIfMemberValuesArePresentInResponse. The value 1 may have been incorrectly specified in this PR based on the corresponding Rails Json test where the timestamp format is httpdate instead of epoch seconds.

The issue was discovered while upgrading Smithy to 1.50.0 in the smithy-rs repository.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit updates the expected `defaultTimestamp` in a restJson1
defaults test to 2. The value 1 may have been incorrectly copied
from the corresponding test in Rails Json where the timestamp format
is httpdate instead of epoch seconds.
@ysaito1001 ysaito1001 requested a review from a team as a code owner June 28, 2024 16:47
@ysaito1001 ysaito1001 requested a review from kstich June 28, 2024 16:47
github-merge-queue bot pushed a commit to smithy-lang/smithy-rs that referenced this pull request Jul 5, 2024
## Motivation and Context
This PR upgrades Smithy to 1.50.0. The majority of the changes follow
`TODO` added in #3690.
Other than that, a few adjustments needed to be made:
- for the client
- added two failing tests `RestJsonClientPopulatesDefaultValuesInInput`
and `RestJsonClientUsesExplicitlyProvidedMemberValuesOverDefaults` to
known failing tests for the same reason
[here](https://github.com/smithy-lang/smithy-rs/blob/main/codegen-client/src/main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/generators/protocol/ClientProtocolTestGenerator.kt#L72)
- added one broken test (i.e. the upstream test definition is incorrect
but our implementation is correct) to known broken tests per
([smithy#2341](smithy-lang/smithy#2341),
[smithy-rs#3726](#3726 (comment)))
- for the server
- removed `rest-xml-extras.smithy` since
`RestXmlMustSupportParametersInContentType` is now available upstream
Smithy 1.50.0
- added the following to known failing tests (since the `awsJson1_0`
counterparts are already in the list, but we need the server team to
verify this assumption & provide additional `TODO` comments if
necessary)
    - `RestJsonServerPopulatesDefaultsWhenMissingInRequestBody`
    - `RestJsonServerPopulatesDefaultsInResponseWhenMissingInParams`,
-
`RestJsonServerPopulatesNestedDefaultValuesWhenMissingInInResponseParams`

## Testing
Existing tests in CI

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: Zelda Hessler <zhessler@amazon.com>
@kstich kstich merged commit 26ff08f into smithy-lang:main Jul 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants