Adding missing getters to ResourceSchema #2486
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Dec 13, 2024
| @@ -231,6 +231,14 @@ public Map<String, Remote> getRemotes() { | |||
| return remotes; | |||
| } | |||
|
|
|||
| public Set<String> getRequired() { | |||
There was a problem hiding this comment.
The current ordering of getters matches the class's properties at definition for ease of use, let's put these in their matching locations - required after properties and additionalProperties at the end.
yasmewad
force-pushed
the
cfn-resource-getter
branch
from
59ad767 to
902186b
Compare
kstich
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
requiredfield from a CFN resourceSchema, I realized that therequiredandadditionalPropertiesfield do not have a getter making it impossible to retrieve therequiredfield in CFN ResourceSchema via the ResourceSchema model.Testing
gradle buildBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.