Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require JDK17+ for development #2487

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

haydenbaker
Copy link
Contributor

Background

  • Given JDK8 is largely being moved away from, this is a good first step in that direction
  • However, for backwards compatibility, we will still target 8 for all current modules
    • This means existing modules cannot use newer features, but new modules (like docgen) can use newer language versions
    • Speaking optimistically, some day we can remove explicit compatibility and just rely on the toolchain

Testing

  • ./gradlew clean build integ publish
  • Set global Java to <17, and run again, does not build and shows error

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haydenbaker haydenbaker requested a review from a team as a code owner December 13, 2024 19:59
@haydenbaker haydenbaker requested a review from yasmewad December 13, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants