fix: recaps are sometimes not available

For example, right after a game finishes the api does not respond with any recap info. This was causing an exception that has since been fixed.
smoak · Dec 5, 2023 · ae37c63 · ae37c63 · vercel · Dec 5, 2023
1 parent 43bb9ac
commit ae37c63
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/app/api/gamecenter/types.ts b/app/api/gamecenter/types.ts
@@ -55,7 +55,7 @@ export type GamecenterBoxscoreFinishedGame = GamecenterBaseResponse & {
   readonly period: number;
   readonly periodDescriptor: PeriodDescriptor;
   readonly gameState: "OFF" | "FINAL";
-  readonly gameVideo: {
+  readonly gameVideo?: {
     readonly threeMinRecap: number;
     readonly condensedGame: number;
   };

diff --git a/app/components/GameSummary/GameRecapButtons/index.tsx b/app/components/GameSummary/GameRecapButtons/index.tsx
@@ -23,6 +23,11 @@ export const GameRecapButtons = ({ game }: GameRecapButtonsProps) => {
   }
 
   const { threeMinRecap, condensedGame } = game;
+
+  if (!threeMinRecap || !condensedGame) {
+    return null;
+  }
+
   const onCondensedGameClicked = () => {
     setVideoPlayerState({
       clipId: condensedGame,

diff --git a/app/components/types.ts b/app/components/types.ts
@@ -81,8 +81,8 @@ export type FinalGame =
       readonly gameState: "Final";
       readonly gameStats: GameStats;
       readonly endedInPeriod: number;
-      readonly threeMinRecap: number;
-      readonly condensedGame: number;
+      readonly threeMinRecap?: number;
+      readonly condensedGame?: number;
     };
 
 export type Game = LiveGame | ScheduledGame | FinalGame;

diff --git a/app/data/normalization.ts b/app/data/normalization.ts
@@ -75,8 +75,6 @@ const normalizeFinalGame: NormalizeFinalGame = (game, teamRecords) => {
       },
     },
     type: ApiGameTypeToGameType[game.gameType],
-    condensedGame: 0,
-    threeMinRecap: 0,
   };
 };
 

diff --git a/app/data/normalization/gameDetails/index.ts b/app/data/normalization/gameDetails/index.ts
@@ -69,8 +69,8 @@ const normalizeFinishedGame = (
     },
     id: game.id,
     type: ApiGameTypeToGameType[game.gameType],
-    condensedGame: game.gameVideo.condensedGame,
-    threeMinRecap: game.gameVideo.threeMinRecap,
+    condensedGame: game.gameVideo?.condensedGame,
+    threeMinRecap: game.gameVideo?.threeMinRecap,
   };
 };
-Original file line number
+Diff line change
@@ Expand Up @@
           },
         },
         type: ApiGameTypeToGameType[game.gameType],
-        condensedGame: 0,
-        threeMinRecap: 0,
       };
     };
@@ Expand Down @@