Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependency Masterminds/sprig to v3.2+ #211

Closed
Kiliandeca opened this issue Aug 5, 2021 · 2 comments · Fixed by #212
Closed

Upgrade dependency Masterminds/sprig to v3.2+ #211

Kiliandeca opened this issue Aug 5, 2021 · 2 comments · Fixed by #212
Labels
dependencies Pull requests that update a dependency file feature-request New feature or request

Comments

@Kiliandeca
Copy link
Contributor

Hi, first of all thank you for this awesome tool, i'm trying to add some randomess in my dynamic responses.
The randInt function was added to Masterminds/sprig in v3.2.0 but Smocker currently use v3.1.0, is it possible to upgrade this dependency and publish a new version of smocker ?

Masterminds/sprig changelog
@Thiht Thiht added dependencies Pull requests that update a dependency file feature-request New feature or request labels Aug 5, 2021
@Thiht
Copy link
Collaborator

Thiht commented Aug 5, 2021

Yep, I'll do that ASAP :)

I actually followed the pull request on Sprig (Masterminds/sprig#211 (comment)) just for this but didn't know it's been merged, thanks for the heads up!

@Thiht Thiht mentioned this issue Aug 5, 2021
Merged
@Thiht Thiht closed this as completed in #212 Aug 5, 2021
@Thiht
Copy link
Collaborator

Thiht commented Aug 5, 2021

Released in 0.16.3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature-request New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update sprig smocker-dev/smocker
2 participants
@Thiht @Kiliandeca