Add rand int #211
Merged
Add rand int #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added description of randInt function
Function added
Closed
|
Nice! Does rand get seeded anywhere? I don't see any call to |
|
Oh. Yep. I forgot about it. Going to update it |
mholt
reviewed
Nov 6, 2019
functions.go
Outdated
| @@ -199,7 +199,10 @@ var genericMap = map[string]interface{}{ | |||
| } | |||
| return val | |||
| }, | |||
| "randInt": func(min, max int) int { return rand.Intn(max-min) + min }, | |||
| "randInt": func(min, max int) int { | |||
| rand.Seed(time.Now().UnixNano()) | |||
There was a problem hiding this comment.
This should be done only once, preferably:
func init() {
rand.Seed(time.Now().UnixNano())
}
kochurovro
force-pushed
the
add--randInt
branch
from
d5cd86b
to
73d60f5
Compare
|
@mholt what u think about my solution for TestShuffle? Is it correct for test? |
|
I don't really know why it had to change, but at a cursory glance it looks fine, as the tests appear to be passing, so, that's a good sign. |
|
Hi, any news on this PR? :) |
technosophos
approved these changes
Nov 30, 2020
Co-authored-by: Daniel <daniel.hoherd@gmail.com>
Signed-off-by: Matt Farina <matt@mattfarina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.