Fix copy replay button functionality #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoeenCoder
reviewed
Jan 7, 2024
|
Thanks again for the review (and for fixing my missing semicolon!) |
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown-client
that referenced
this pull request
Mar 25, 2024
Co-authored-by: HoeenHero <HoeenCoder@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy replay link button functionality was previously not working. This might not be the best way to "fix" that, as there is an existing copyReplayLink function present in the same file.
This is my quick-and-inelegant solution with the purpose of possibly providing a short term solution until a better one can be found.
Thanks!