Skip to content

Commit

Permalink
Slowchat: Don't announce when the setting changes
Browse files Browse the repository at this point in the history
  • Loading branch information
@HoeenCoder
HoeenCoder committed Sep 24, 2018
1 parent f77d8d6 commit df1b799
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions chat-plugins/roomsettings.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -410,14 +410,12 @@ exports.commands = {
if (this.meansNo(target)) {
if (!room.slowchat) return this.errorReply(`Slow chat is already disabled in this room.`);
room.slowchat = false;
this.add("|raw|<div class=\"broadcast-blue\"><strong>Slow chat was disabled!</strong><br />There is no longer a set minimum time between messages.</div>");
} else if (targetInt) {
if (!user.can('bypassall') && room.userCount < SLOWCHAT_USER_REQUIREMENT) return this.errorReply(`This room must have at least ${SLOWCHAT_USER_REQUIREMENT} users to set slowchat; it only has ${room.userCount} right now.`);
if (room.slowchat === targetInt) return this.errorReply(`Slow chat is already set to ${room.slowchat} seconds in this room.`);
if (targetInt < SLOWCHAT_MINIMUM) targetInt = SLOWCHAT_MINIMUM;
if (targetInt > SLOWCHAT_MAXIMUM) targetInt = SLOWCHAT_MAXIMUM;
room.slowchat = targetInt;
this.add(`|raw|<div class="broadcast-red"><strong>Slow chat was enabled!</strong><br />Messages must have at least ${room.slowchat} seconds between them.</div>`);
} else {
return this.parse("/help slowchat");
}
Expand Down

5 comments on commit df1b799

@panpawn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this setting being changed is pretty relevant to regular users, as it effects their messages the most - that's why I designed it to announce it. What's the reasoning to not?

@Zarel
Copy link
Member

@Zarel Zarel commented on df1b799 Sep 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it tends to cause alot of problems with regs going nuts with messages like "were free!" ect when its turned off

@panpawn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the modchat notification do the same thing :P?

@Zarel
Copy link
Member

@Zarel Zarel commented on df1b799 Sep 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but that one's a bit more important for people to know.

@HoeenCoder
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With modchat they would need to know since it may affect their ability to speak at all in the room, slowchat settings only slows their messages down. Also generally modchat + (and up) is used only for a short period and dosen't cause this to this extent.

Please sign in to comment.