Seasons: Fix JSON parsing error for ladder top retrieval #10745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request addresses a recurring JSON parsing error (“Unexpected token <”) when fetching ladder top data. The code now validates the response before parsing, gracefully handles non-JSON responses, and prevents crashes by returning null if the data is invalid. This ensures that unexpected server responses (such as HTML errors) no longer cause runtime exceptions.
- Replaced spaces with tabs in server/chat-plugins/seasons.ts. - Resolved eslint errors related to indentation.
|
Please also check that |
|
@Slayer95 added the extra safety checks. |
Slayer95
reviewed
Dec 8, 2024
Slayer95
reviewed
Dec 8, 2024
|
@Slayer95 feedback is processed. |
|
Thanks! It should be good now. Also, validating the current period is a nice catch. |
mia-pi-git
reviewed
Dec 17, 2024
Co-authored-by: Mia <49593536+mia-pi-git@users.noreply.github.com>
DieterReinert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a recurring JSON parsing error (“Unexpected token <”) when fetching ladder top data. The code now validates the response before parsing, gracefully handles non-JSON responses, and prevents crashes by returning null if the data is invalid. This ensures that unexpected server responses (such as HTML errors) no longer cause runtime exceptions.