Fix TypeError When Room Cache Is Undefined #10748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined This PR addresses a ``TypeError`` that occurs in the ``runActions`` function when attempting to access the ``staffNotified`` property of an undefined ``cache[room.roomid]``. By adding a conditional check, the function now safely skips the notification logic if the room cache does not exist, preventing runtime crashes.
…rror when room cache is undefined
|
I resolved this in a slightly different way, to avoid skipping potentially necessary steps. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeErrorthat occurs in therunActionsfunction when attempting to access thestaffNotifiedproperty of an undefinedcache[room.roomid]. By adding a conditional check, the function now safely skips the notification logic if the room cache does not exist, preventing runtime crashes.