Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add September RoA Spotlight, LCotM, and OMotM #4838

Merged
merged 5 commits into from
Sep 1, 2018
Merged

Add September RoA Spotlight, LCotM, and OMotM #4838

merged 5 commits into from
Sep 1, 2018

Conversation

@KrisXV KrisXV changed the title Add September RoA Spotlight Add September RoA Spotlight, LCotM, and OMotM Aug 31, 2018
// @ts-ignore
set.sketchMove = move.id;
return null;
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TI asked me about event-locked moves, but I was out that day, and my computer rebooted to install updates before I could remember to reply. Sorry about that.
Anyway, in answer to his question, I don't actually know whether sketching event-locked moves was ever supported, although I do know I had some interim code which basically went through each sketchable move temporarily deleting it from the set in the hope that it would validate without that move. I suspect that version would have worked with event-locked moves, but it was really ugly.

name: "[Gen 7] Benjamin Butterfree",
desc: `Pokémon that faint reincarnate as their prevo, but without the moves they can't learn.`,
name: "[Gen 7] Partners in Crime",
desc: "Doubles-based metagame where both active ally Pokémon share abilities and moves.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong sort of quotes? (I really should update ROM some time...)

}
},
onFaint: function (pokemon) {
// this.add('-hint', 'checking ally ability after faint of ' + pokemon);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like I have three lines of old debugging code that I need to delete...

@TheImmortal
Copy link
Contributor

Your Sketchmons bans are outdated btw @urkerab

@TheImmortal TheImmortal merged commit 5813add into smogon:master Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants