Add /notifyrank #4858
Merged
Add /notifyrank #4858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zarel
reviewed
Sep 22, 2018
chat-commands.js
Outdated
| } | ||
| }, | ||
| tempnotifyrankhelp: [`/tempnotifyrank [rank], [title], [message] - Sends a notification to everyone with the specified rank or higher. Requires: # * & ~`], | ||
| tempnotifyoffrankhelp: [`/tempnotifyoffrank [rank] - Closes the notification previously sent with /tempnotifyrank [rank]. Requires: # * & ~`], |
There was a problem hiding this comment.
You would generally make this one Help entry, so /tempnotifyrank and /tempnotifyoffrank would both show both help lines.
There was a problem hiding this comment.
Oh right, will do.
|
I'm not sure if the word "temp" needs to be in the command name. |
|
I would maybe add a small note "notification from X" for non-global bots, and tie it to bot permissions. |
|
I believe |
|
Updated with those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently planned to be used in conjunction with
/addrankhtmlboxin Tournaments, but I can see it being useful for other rooms too.