Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bandpass Butterworth filter order to get a better filter, add option to change order in CLI #90

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

smoia
Copy link
Owner

@smoia smoia commented Aug 13, 2023

Addresses and possibly fixes #89
@farnazdelavari if you can test again the new version of the code vs your matlab impementation, I'd appreciate it.

Proposed Changes

  • Changes default Butterworth filter order from 1 to 9 to get a steeper change
  • Add option to change order in filter function, workflow, and CLI

Not super-happy about how the power spectra post-filtering looks like, a bit more work might be needed here!

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) label Aug 13, 2023
@smoia smoia merged commit ca5257e into master Aug 13, 2023
@smoia
Copy link
Owner Author

smoia commented Aug 13, 2023

🚀 PR was released in 0.18.1 🚀

@smoia smoia added the Released This PR has been released! label Aug 13, 2023
@smoia smoia deleted the fix/bandpass branch September 8, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) Released This PR has been released!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible problem in bandpass filtering
1 participant