This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Added 'subnetGroup' option #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid making unsupported subnet group in specific region
|
This looks great. Can you add a test for it? |
jplock
suggested changes
May 31, 2019
geoseong
commented
Jun 2, 2019
geoseong
commented
Jun 2, 2019
| const expected = getSubnetGroupsOptions.reduce((acc, key) => Object.assign(acc, subnetGroupList[key]), {}) | ||
| const actual = buildSubnetGroups(2, getSubnetGroupsOptions) | ||
| expect(actual).toEqual(expected); | ||
| expect.assertions(1); |
There was a problem hiding this comment.
I think this code is unnecessary because no asynchronous code is here. but I just put it on your style :)
jplock
suggested changes
Jun 2, 2019
src/subnet_groups.js
Outdated
| } | ||
| if (subnetGroups.length > 0) { | ||
| return subnetGroups.reduce(function(acc, service) { | ||
| let builtSubnetGroup = subnetGroupList[service.toLowerCase()](numZones); |
There was a problem hiding this comment.
Can we add a check here to ensure service is a valid key in subnetGroupList before trying to call it?
There was a problem hiding this comment.
I added it in src/index.js.
I think this is unavoidable to input validation logic into src/index.js.
because I don't want to get dirty importing serverless.classes.Error object on src/subnet_groups.js
jplock
approved these changes
Jun 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I really appreciated to create this plugin. This is really nice~!
so I decided to use this plugin every project since now, but I faced some problem.
I work on
Seoulregion(ap-northeast-2).DAXis not available in my regionso I added the option named
subnetGroup.subnetGroup can pick subnet groups which user want to create.
Adding this options, I could avoid the error this plugin tried to make DAX Subnet group.
please consider to be merged.
Thank you~!