Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly implement connection shutdowns in collection.rs #391

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Properly implement connection shutdowns in collection.rs #391

wants to merge 1 commit into from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Apr 4, 2023

Very work in progress

@tomaka
Copy link
Contributor Author

tomaka commented Apr 5, 2023

While the changes in collection.rs are (tough but) mechanical, I'm unsure how to propagate these changes to peers.rs and service.rs. At the moment, they aren't capable of handling half-closed connections. In particular, service.rs automatically unallocates the peer's slot when its connection is shutting down.

Maybe doing #60 first is a better idea.

@tomaka tomaka mentioned this pull request Sep 28, 2023
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Oct 28, 2023

This can now be worked upon again after #1200. However I'll most likely open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomaka