Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the timers API #507

Merged
merged 1 commit into from
May 3, 2023
Merged

Simplify the timers API #507

merged 1 commit into from
May 3, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented May 3, 2023

Now that #505 is in, start_timer_wrap is only ever called from within the timers module. This makes the timerId parameter quite useless. As such, this PR removes it.

Note that we could in theory pass "now" to timer_finished in order to save a function call, but this would punch through abstraction layers given that Instant is in the stdlib.

@tomaka tomaka added this pull request to the merge queue May 3, 2023
Merged via the queue into smol-dot:main with commit 801d838 May 3, 2023
@tomaka tomaka deleted the timers-simplifyt branch May 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomaka