Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce syscalls in Async::new #107

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Reduce syscalls in Async::new #107

merged 1 commit into from
Dec 30, 2022

Conversation

taiki-e
Copy link
Collaborator

@taiki-e taiki-e commented Dec 30, 2022

See smol-rs/async-process#31 (comment) for the context.

@taiki-e taiki-e requested a review from notgull December 30, 2022 05:46
@@ -20,6 +20,7 @@ harness = false

[dependencies]
async-lock = "2.6"
cfg-if = "1"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(polling already depends on cfg-if, so this doesn't increase number of dependencies)

@taiki-e taiki-e merged commit 9b46fc0 into master Dec 30, 2022
@taiki-e taiki-e deleted the taiki-e/syscalls branch December 30, 2022 06:59
@notgull notgull mentioned this pull request Mar 21, 2023
notgull added a commit that referenced this pull request Mar 22, 2023
- Use [`rustix`] instead of [`libc`]/[`windows-sys`] for system calls (#76)
- Add a `will_fire` method to `Timer` to test if it will ever fire (#106)
- Reduce syscalls in `Async::new` (#107)
- Improve the drop ergonomics of `Readable` and `Writable` (#109)
- Change the "`wepoll`" in documentation to "`IOCP`" (#116)

[`rustix`]: https://crates.io/crates/rustix/
[`libc`]: https://crates.io/crates/libc/
[`windows-sys`]: https://crates.io/crates/windows-sys/
notgull added a commit that referenced this pull request Apr 28, 2023
- Use [`rustix`] instead of [`libc`]/[`windows-sys`] for system calls (#76)
- Add a `will_fire` method to `Timer` to test if it will ever fire (#106)
- Reduce syscalls in `Async::new` (#107)
- Improve the drop ergonomics of `Readable` and `Writable` (#109)
- Change the "`wepoll`" in documentation to "`IOCP`" (#116)

[`rustix`]: https://crates.io/crates/rustix/
[`libc`]: https://crates.io/crates/libc/
[`windows-sys`]: https://crates.io/crates/windows-sys/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants