Use rustix abstraction to support I/O Safety unconditionally #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustix (via io-lifetimes) always provides the I/O Safety types and traits. On newer Rust it re-exports them from the standard library; on older Rust it defines its own. We already depend on those types (e.g. `rustix::fd::BorrowedFd`) in our implementation. Use the rustix types so that we can support I/O Safety unconditionally. Note that on Windows, rustix exports `BorrowedFd`/`OwnedFd` types that are really `BorrowedSocket`/`OwnedSocket`. Work around this in the implementation by renaming them back.
notgull
reviewed
Jun 6, 2023
There was a problem hiding this comment.
Thanks!
In less than a week from now, Debian Bookworm will release as the new Debian Stable, containing a rustc with version 1.63. This means that we can use this version as per our tentative MSRV policy (see smol-rs/smol#244). I would rather just wait and then use AsFd and friends from libstd, rather than re-export types from rustix, which tends to be very unstable.
|
Closing in favor of #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustix (via io-lifetimes) always provides the I/O Safety types and
traits. On newer Rust it re-exports them from the standard library; on
older Rust it defines its own. We already depend on those types (e.g.
rustix::fd::BorrowedFd) in our implementation.Use the rustix types so that we can support I/O Safety unconditionally.
Note that on Windows, rustix exports
BorrowedFd/OwnedFdtypes thatare really
BorrowedSocket/OwnedSocket. Work around this in theimplementation by renaming them back.