don't busy wait in SemaphoreGuard::acquire_arc #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
requested changes
May 15, 2023
tests/mutex.rs
Outdated
| future::block_on(async { | ||
| let m = Mutex::new(()); | ||
| let _g = m.try_lock().unwrap(); | ||
| assert!(future::poll_once(m.lock()).await.is_none()); |
There was a problem hiding this comment.
This test should also make sure that the future wakes back up once the other lock is dropped. Ditto for all of the others.
There was a problem hiding this comment.
Does it suffice to check that the future now returns Ready or do you want to check that the Waker was triggered? I can do the latter but I think I'd need to add waker-fn as a dev dependency to do it cleanly.
There was a problem hiding this comment.
Doing both would be nice. It's fine to add waker-fn as a dev dependency, since it's already brought in via futures-lite.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
I also added a test for this for each of
Mutex/RwLock/Semaphore. The existing tests almost all use different threads when tasks contend for locks so they wouldn't catch this.