Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove boxed futures from TcpStream and UnixStream #15

Merged
merged 1 commit into from
May 22, 2021
Merged

Remove boxed futures from TcpStream and UnixStream #15

merged 1 commit into from
May 22, 2021

Conversation

taiki-e
Copy link
Collaborator

@taiki-e taiki-e commented May 22, 2021 •
edited
Loading

depend on smol-rs/async-io#64 UPD: released async-io 1.5.0 UPD2: yanked 1.5.0

fyi @erickt, @Kestrer, @yoshuawuyts, async-rs/async-std#969

@taiki-e taiki-e force-pushed the taiki-e/box branch 4 times, most recently from 724fb34 to 1f839d6 Compare May 22, 2021 12:24
yoshuawuyts
yoshuawuyts approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! — This seems like it might meaningfully speed up async I/O!

@taiki-e taiki-e merged commit 8b199ea into master May 22, 2021
@taiki-e taiki-e deleted the taiki-e/box branch May 22, 2021 13:05
@taiki-e taiki-e mentioned this pull request May 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @yoshuawuyts