Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change executor grow_pool function error_span to tracing_span #45

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

leonzchang
Copy link
Contributor

@leonzchang leonzchang commented Sep 28, 2023

After I update blocking dependency to v1.4.0, this error log pop up.
grow_pool; queue_len=1 idle_count=0 thread_count=0

I think this might just a typo for trace level? (cc #40)

blocking/src/lib.rs

Lines 246 to 254 in c3b5e01

/// Spawns more blocking threads if the pool is overloaded with work.
fn grow_pool(&'static self, mut inner: MutexGuard<'static, Inner>) {
let span = tracing::error_span!(
"grow_pool",
queue_len = inner.queue.len(),
idle_count = inner.idle_count,
thread_count = inner.thread_count,
);
let _enter = span.enter();

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 23a26e9 into smol-rs:master Oct 6, 2023
@notgull notgull mentioned this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants