feat: Add a loom implementation for event-listener #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
requested changes
Mar 30, 2024
notgull
added a commit
to smol-rs/concurrent-queue
that referenced
this pull request
Mar 30, 2024
I'm unsure why this wasn't added to begin with. This adds Loom testing to the CI with a low number of max pre-emptions, in order to avoid making the test take forever. cc smol-rs/event-listener#126 (comment) Signed-off-by: John Nunley <dev@notgull.net>
|
I added Loom to the CI in smol-rs/concurrent-queue#62. It looks like it works. Maybe it's the optional feature flag that's gumming it up. |
notgull
added a commit
to smol-rs/concurrent-queue
that referenced
this pull request
Mar 30, 2024
I'm unsure why this wasn't added to begin with. This adds Loom testing to the CI with a low number of max pre-emptions, in order to avoid making the test take forever. cc smol-rs/event-listener#126 (comment) Signed-off-by: John Nunley <dev@notgull.net>
|
I think and here: |
To be clear, it's not that the concurrent-queue loom tests are failing, or even that concurrent-queue can't build under loom. This PR for event listener correctly builds concurrent-queue under loom and runs tests against concurrent-queue loom. The issue is this specific scenario for concurrent-queue, which may or may not even matter: |
Merged
notgull
added a commit
that referenced
this pull request
Apr 14, 2024
Mirrors #126 Signed-off-by: John Nunley <dev@notgull.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loom tests aren't particularly useful yet, but the crate compiles and runs under loom now.
Note: This crate does not currently compile under loom without std because concurrent-queue does not compile with that combination (can't find spin_loop).
closes #23