Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that EventListeners must be listen'd on #90

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Document that EventListeners must be listen'd on #90

merged 2 commits into from
Oct 19, 2023

Commits on Oct 18, 2023

  1. docs: Document that EventListeners must be listen'd on 

    In retrospect it is sometimes unclear in the documentation that the new event
listener needs to be pinned and inserted into the list before it can receive
events. This PR adds documentation that should clarify this issue.

Closes #89

Signed-off-by: John Nunley <dev@notgull.net>
    @notgull
    notgull committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    ac3978e View commit details
    Browse the repository at this point in the history

  2. Fix doctest and nitpick 

    Signed-off-by: John Nunley <dev@notgull.net>
    @notgull
    notgull committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    5c11241 View commit details
    Browse the repository at this point in the history