Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedoxOS Support #176

Closed
notgull opened this issue Jan 13, 2024 · 2 comments · Fixed by #190
Closed

RedoxOS Support #176

notgull opened this issue Jan 13, 2024 · 2 comments · Fixed by #190

Comments

@notgull
Copy link
Member

notgull commented Jan 13, 2024

x86_64-unknown-redox supports event schemes which are apparently the preferred way to poll for events. However I can't find any documentation that indicates how stable it is.

It also supports epoll, but this isn't exposed in rustix yet.
@notgull notgull mentioned this issue Jan 13, 2024
Open
@rw-vanc
Copy link

rw-vanc commented Jan 13, 2024

Event schemes are quite stable and are used extensively in Redox. However, they are very Redox-specific. epoll will be a perfectly fine way to go in the short term. When we are ready to do a full Redox-Rustix, we will use the Rust-only parts of relibc (Redox's libc implementation) as a base.

@jackpot51
Copy link

epoll in redox is a very thin and efficient wrapper around the Redox event scheme, so it is best to use that.

notgull added a commit to forkgull/rustix that referenced this issue Jan 13, 2024
@notgull
Add epoll support for Redox
ef6b691 
For now it seems that epoll is the preferred way to access Redox's
underlying polling interface. There are event schemes but until Redox's
syscalls are better integrated with Rustix it's probably not worth it
yet.

cc smol-rs/polling#176

Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull mentioned this issue Jan 13, 2024
Merged
sunfishcode pushed a commit to bytecodealliance/rustix that referenced this issue Jan 16, 2024
@notgull
Add epoll support for Redox (#985)
916887b 
For now it seems that epoll is the preferred way to access Redox's
underlying polling interface. There are event schemes but until Redox's
syscalls are better integrated with Rustix it's probably not worth it
yet.

cc smol-rs/polling#176

Signed-off-by: John Nunley <dev@notgull.net>
notgull added a commit that referenced this issue Feb 10, 2024
@notgull
feat: Add RedoxOS epoll
223f23a 
Technically RedoxOS supports the poll syscall, so we already support
RedoxOS. However, this is very slow. This commit ports this code to
epoll, which should be more efficient.

Closes #176

Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull mentioned this issue Feb 10, 2024
Merged
notgull added a commit that referenced this issue Feb 11, 2024
@notgull
feat: On RedoxOS, use epoll instead of the poll backend
77b4ed1 
Technically RedoxOS supports the poll syscall, so we already support
RedoxOS. However, this is very slow. This commit ports this code to
epoll, which should be more efficient.

Closes #176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RedoxOS Epoll smol-rs/polling
3 participants
@jackpot51 @notgull @rw-vanc