Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix Android breakage #99

Merged
merged 6 commits into from
Mar 22, 2023
Merged

ci: Fix Android breakage #99

merged 6 commits into from
Mar 22, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Mar 18, 2023

Uses a workaround for cross-rs/cross#1128 and rust-lang/rust#103673

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 18, 2023

We maybe also need to update cross version to the latest.

From:

uses: taiki-e/install-action@v2
with:
# https://github.com/cross-rs/cross/issues/724
tool: cross@0.2.1

To:

       uses: taiki-e/install-action@cross

@notgull
Copy link
Member Author

notgull commented Mar 18, 2023

Hmm, looks like the new version broke the other targets. Not sure if there's a way around this.

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 18, 2023

I think rustup target add+cargo build --target would work for targets that cross does not support. (This crate is a library and does not require a linker or libraries to build the library part.)

rustup target add x86_64-unknown-illumos
cargo build --target x86_64-unknown-illumos

@notgull
Copy link
Member Author

notgull commented Mar 21, 2023

Looks like the FreeBSD/NetBSD builds are failing here... actually, can we just remove them, since we're testing them anyways using Cirrus/vmactions?

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 21, 2023

Yeah, there is no need to build NetBSD and FreeBSD by using cross as they have been tested elsewhere.


freebsd_task:

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 21, 2023

we're testing them anyways using Cirrus/vmactions

Yeah, there is no need to build NetBSD and FreeBSD by using cross as they have been tested elsewhere.

It may be a good idea to leave a comment on cross job about we are testing BSDs using Cirrus/vmactions.


Also you may need to change the target triple for Fuchsia from x86_64-fuchsia to x86_64-unknown-fuchsia.

https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1680-2023-03-09

Add vendor to Fuchsia's target triple

Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit e340458 into master Mar 22, 2023
@notgull notgull deleted the notgull/android-fix branch March 22, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants