-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix Android breakage #99
Conversation
We maybe also need to update cross version to the latest. From: polling/.github/workflows/ci.yml Lines 79 to 82 in e10c7e8
To: uses: taiki-e/install-action@cross |
Hmm, looks like the new version broke the other targets. Not sure if there's a way around this. |
I think polling/.github/workflows/ci.yml Lines 100 to 101 in e10c7e8
|
Looks like the FreeBSD/NetBSD builds are failing here... actually, can we just remove them, since we're testing them anyways using Cirrus/vmactions? |
Yeah, there is no need to build NetBSD and FreeBSD by using cross as they have been tested elsewhere. polling/.github/workflows/ci.yml Line 103 in e10c7e8
Line 13 in e10c7e8
|
It may be a good idea to leave a comment on cross job about we are testing BSDs using Cirrus/vmactions. polling/.github/workflows/ci.yml Line 68 in e10c7e8
Also you may need to change the target triple for Fuchsia from x86_64-fuchsia to x86_64-unknown-fuchsia. https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1680-2023-03-09
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Uses a workaround for cross-rs/cross#1128 and rust-lang/rust#103673