Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log and drop ipv6 packets requiring fragmentation #1038

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Easyoakland
Copy link
Contributor

@Easyoakland Easyoakland commented Jan 28, 2025

Currently packets which exceed the MTU are still transmitted for ipv6 without regard for their size.

This pr changes the behavior for ipv6 to match the behavior for ipv4: drop packet and net_debug instead of trying to transmit. This prevents panics in Device implementations that assume the given packet doesn't exceed an MTU in size.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (49cc60a) to head (bef9b05).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/iface/interface/mod.rs 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   80.84%   80.84%   -0.01%     
==========================================
  Files          81       81              
  Lines       28481    28485       +4     
==========================================
+ Hits        23026    23029       +3     
- Misses       5455     5456       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the comment!

src/iface/interface/mod.rs Outdated Show resolved Hide resolved
@whitequark
Copy link
Contributor

Thanks! If you squash the commits I'll hit merge.

ipv6 -> IPv6

Co-authored-by: Catherine <whitequark@whitequark.org>
@Easyoakland
Copy link
Contributor Author

Done.

@whitequark whitequark added this pull request to the merge queue Jan 29, 2025
@whitequark
Copy link
Contributor

Thanks for the PR and the prompt response!

Merged via the queue into smoltcp-rs:main with commit 3e3afb6 Jan 29, 2025
12 checks passed
@Easyoakland Easyoakland deleted the ipv6-drop-fragment branch January 30, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants