Fix packet buffer panic caused by large payload #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When packet buffer's payload buffer does not have enough contiguous window left, the ring buffer roll over uses an incorrect size causing the ring buffer pointer not resetting to the head. When the payload enqueued is larger than 1/2 of the payload ring buffer, this bug will cause the slice returned by `PacketBuffer::enqueue` to not match the requested size, and trigger `debug_assert` in debug profile or size mismatch panic in `copy_from_slice` when compiled in release profile.
whitequark
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packet buffer's payload buffer does not have enough contiguous
window left, the ring buffer roll over uses an incorrect size
causing the ring buffer pointer not resetting to the head.
When the payload enqueued is larger than 1/2 of the payload ring
buffer, this bug will cause the slice returned by
PacketBuffer::enqueueto not match the requested size, andtrigger
debug_assertin debug profile or size mismatch panic incopy_from_slicewhen compiled in release profile.