Do not send window updates in states that shouldn't do so. #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the window update was sent anytime it changed. This is not desirable for 2 reasons: - It would send window updates in TimeWait or Closed states, which is incorrect. - It would send window updates in states where we've already received the remote side's FIN, such as CloseWait. This is not necessarily incorrect, but is useless, since the remote side is not going to send us more data, therefore it's not interested in our window size anymore.
whitequark
approved these changes
Jun 25, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #358, but not only. I've noticed that window updates are also sent in CloseWait and Closed states, which is actually incorrect.
This PR adds two previously-failing tests.
Previously, the window update was sent anytime it changed. This is
not desirable for 2 reasons:
remote side's FIN, such as CloseWait. This is not necessarily incorrect, but
is useless, since the remote side is not going to send us more data, therefore
it's not interested in our window size anymore.