-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Actions for CI #390
Conversation
177c3b2
to
bb3d612
Compare
Nice! |
b442bc9
to
14e1f3f
Compare
Ok, this is ready for review. At the moment Travis is still enabled too, but we could remove it in this PR. |
Thank you for tackling this! As far as I'm concerned this is ready. You can just get rid of Travis. |
I'm not sure who can actually merge this PR though; for some reason I don't have the permission bit for manually merging to protected branches, and the Travis required status will never pass now. |
I guess @jordens? I was previously an admin of the organisation but apparently no longer, so I can't disable the Travis required check either. |
I'm pretty sure I had repo admin at one point but seemingly no longer? No idea what's up with that. |
I also don't have the necessary permissions. |
I don't know why or who set these permissions up, I don't think it makes sense and it doesn't seem desirable to me. I have made the three of you owners. |
Thanks! |
To ensure the long-term health of the project, I went ahead and did two things:
I think smoltcp has a great future ahead of it, and I look forward to seeing it evolve in 2021 with a new maintainer. |
This is a first attempt at resolving #389. I expect it will need some fine-tuning; feedback welcome.
I believe I've included everything from the current Travis config except for checking the bench, which seems to be broken at the moment anyway.
Edit: It seems like building on 1.28.0 is broken as it can't parse the
Cargo.toml
file ofcfg-if
or other dependencies, although the README suggests that should be the MSRV. It looks like even once that issue is resolved, the use ofMaybeUninit
requires 1.36, which does build OK, so I've set a check at 1.36 in the CI and updated README.Edit 2: It looks like the test without std is failing due to a whole bunch of errors; I've removed it for now.
Edit 3: Tests just won't pass without std or alloc, so I've swapped it to only check the build for that feature-set.