Fix feature-related compilation issues. #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
fix-bad-features
branch
4 times, most recently
from
28c19ef
to
defd81c
Compare
Dirbaio
force-pushed
the
fix-bad-features
branch
from
defd81c
to
bc0ffb6
Compare
crawford
approved these changes
Mar 24, 2021
Closed
I think this is a reasonable decision. That's what I aimed to do anyway, but I think at the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is that every combination of features either:
I've opted to make "no ipv4 and no ipv6" an unsupported combination. It could be made to work but I don't think it's worth it.
Fixed cases:
(no features)-> now fails withYou must enable at least one of the following features: proto-ipv4, proto-ipv6. Fixes 0.7 build error #428 (comment)proto-ipv4,socket-> now fails withIf you enable the socket feature, you must enable at least one of the following features: socket-raw, socket-udp, socket-tcp, socket-icmp. Fixes 0.7 build error #428 (comment)ethernet-> now correctly enablessocketfeature, and then fails with the error above.proto-dhcpv4-> now correctly enablesethernetfeature.proto-ipv4,phy-tap_interface-> now correctly enablesethernetfeature.fixes #428
Will be cherry-picked for 0.7.1 release