Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeval in phy_wait for times greater than 1 second #449

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Fix timeval in phy_wait for times greater than 1 second #449

merged 2 commits into from
Mar 24, 2021

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Mar 24, 2021

I'm not sure what's going on because this used to work fine, but now some examples like httpclient fail with this error:

thread 'main' panicked at 'wait error: Os { code: 22, kind: InvalidInput, message: "Invalid argument" }', examples/httpclient.rs:105:61

Turns out select() doesn't like it that tv_usec >= 1e6.

@Dirbaio Dirbaio enabled auto-merge March 24, 2021 02:13
@Dirbaio Dirbaio merged commit 1f50d1a into master Mar 24, 2021
@Dirbaio Dirbaio deleted the fix-phywait branch March 24, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford crawford approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dirbaio @crawford