Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use micros in Instant and Duration #514

Merged
merged 1 commit into from
Oct 5, 2021
Merged

use micros in Instant and Duration #514

merged 1 commit into from
Oct 5, 2021

Conversation

JakkuSakura
Copy link
Contributor

@JakkuSakura JakkuSakura commented Jul 4, 2021 •
edited
Loading

This improves precision everywhere, especially pcap
#513

Dirbaio
Dirbaio approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great.

I'll probably write a follow-up PR to make the tick rate configurable. I have devices where the time source is 32768hz, having to convert to/from millis/micros is annoying.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 5, 2021

Merge conflict.

@Dirbaio
Copy link
Member

Dirbaio commented Oct 5, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 5, 2021

Build succeeded:

@bors bors bot merged commit f293de4 into smoltcp-rs:master Oct 5, 2021
@Dirbaio Dirbaio mentioned this pull request Oct 7, 2021
Merged
bors bot added a commit that referenced this pull request Oct 7, 2021
@bors @Dirbaio
Merge #545
35e833e 
545: time: fix incorrect conversion from std r=Dirbaio a=Dirbaio

from #514 

cc `@qiujiangkun` 

Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakkuSakura @Dirbaio