Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose underlying device from PcapWriter #524

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Expose underlying device from PcapWriter #524

merged 1 commit into from
Sep 8, 2021

Conversation

bdbai
Copy link
Contributor

@bdbai bdbai commented Aug 24, 2021

PcapWriter should expose an interface for access to the lower Device, similar to Tracer.

Dirbaio
Dirbaio reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you! :)

@Dirbaio Dirbaio merged commit 9e2cbc4 into smoltcp-rs:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdbai @Dirbaio