TCP fuzz fixes #538
Merged
TCP fuzz fixes #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes an infinite loop of zero-length packets: when we have data to send, it sends MSS-length packets until filling the window, which is an infinte amount of packets because mss is zero. Found with cargo-fuzz.
Previous code had an `if` to force sending a packet when retransmitting. When the remote window is zero this would cause an infinite loop of sending empty packets, because the "retransmit" flag would never get cleared. Remove the force-retransmit, and add an explicit check on `seq_to_transmit` for pending SYNs because SYN retransmission relied on it. Found with cargo-fuzz.
THis would let FIN packets through, breaking the logic below. Found with cargo-fuzz.
… low. Found with cargo-fuzz.
…_FFFF. Found with cargo-fuzz.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes panics and hangs found by whole-stack fuzzing. See individual commit messages.
Will post the whole-stack fuzz target when it's fully clean.