socket: simplify, make SocketSet private. #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
socket-refactor
branch
3 times, most recently
from
71ac219
to
0e2c2f6
Compare
Dirbaio
changed the title
Merged
Dirbaio
force-pushed
the
socket-refactor
branch
from
0e2c2f6
to
bbf4599
Compare
Dirbaio
force-pushed
the
socket-refactor
branch
from
bbf4599
to
8a3aaa1
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 4, 2021
573: Simpler rand r=Dirbaio a=Dirbaio Requires #571 Revisits #547, because it turns out the `rand_custom_impl!` macro stuff was less nice than I thought. It's now a simple PRNG owned by Interface. The builder allows setting the random seed. Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net> Co-authored-by: Thibaut Vandervelden <thvdveld@vub.be> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the work started in #557.
Since
Interfacenow owns the sockets,SocketSetis now an implementation detail, so it is made private.Also
SocketMetais moved from each socket to the SocketSet.SocketMetais arguably anInterfaceimplementation detail as well, mainly used for neighbor discovery. it also reduces a bit of code duplication.