Don't error when calling listen again on the same local endpoint.
#841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
force-pushed
the
listen-noop
branch
from
4bcdb05
to
c8fe32f
Compare
Codecov Report
@@ Coverage Diff @@
## main #841 +/- ##
=======================================
Coverage 79.58% 79.58%
=======================================
Files 78 78
Lines 27809 27813 +4
=======================================
+ Hits 22131 22135 +4
Misses 5678 5678
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
whitequark
reviewed
Sep 18, 2023
Provided the local endpoint we are listening to is the same, it is safe to call `listen` multiple times.
MabezDev
force-pushed
the
listen-noop
branch
from
c8fe32f
to
00cde4e
Compare
whitequark
approved these changes
Sep 20, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided the local endpoint we are listening to is the same, it is safe to call
listenmultiple times. Fixes the doc comment for the function too.This isn't much use for this in smoltcp, in embassy-net it's crucial when writing an acceptor loop. Without this, if you try and accept on a socket that's already listening you'll immediately get an error. The only way around this is to first
abortthe socket, but this means that incoming connections can actually get aborted between theabort()and the nextaccept(), as I have sadly experienced myself today 🥲.