Ipv6 source address selection based on RFC 6724 #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scope of an address is used when selecting the source IPv6 address based on the destination address. As the scope is then also used for unicast address, I made the scope only public in the crate instead of outside the crate. Not sure if this should be public or not. This commit also adds the `is_global_unicast` query function for IPv6 addresses.
RFC6724 defines how the source address should be selected when given a destination address. Instead of selecting the first address in the list of interface addresses, the source address is selected following the standard.
thvdveld
force-pushed
the
ipv6-source-address-selection
branch
from
fe3beb0
to
dd9eff7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
==========================================
+ Coverage 79.53% 79.62% +0.08%
==========================================
Files 78 78
Lines 27887 28043 +156
==========================================
+ Hits 22181 22329 +148
- Misses 5706 5714 +8 ☔ View full report in Codecov by Sentry. |
thvdveld
force-pushed
the
ipv6-source-address-selection
branch
from
6c730bc
to
434f7eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of selecting the first address in the interface list of addresses, RFC 6724 is used for selecting the source IPv6 address based on the destination address.
The functions
get_source_address,get_source_address_ipv4andget_source_address_ipv6had a mutable reference to self. However, this seemed not necessary. I made the reference immutable, but maybe someone knows why this was mutable?