Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target-arch names and remove unknonwn fuzzing cfg warning #969

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

thvdveld
Copy link
Contributor

@thvdveld thvdveld commented Aug 5, 2024

The endianness of the target architecture cannot be specified using target_arch. The endianness can be specified using target_endian.

The target description for mipsel-unknown-linux-gnu is found here:
https://github.com/rust-lang/rust/blob/master/compiler/rustc_target/src/spec/targets/mipsel_unknown_linux_gnu.rs
In this specification, the arch is set to "mips" and not "mipsel".

@blechschmidt: since you added this cfg for these architectures, could you check if smoltcp still compiles for you?

The endianness of the target architecture cannot be specified using
target_arch. The endianness can be specified using target_endian.

The target description for mipsel-unknown-linux-gnu is found here:
https://github.com/rust-lang/rust/blob/master/compiler/rustc_target/src/spec/targets/mipsel_unknown_linux_gnu.rs
In this specification, the arch is set to "mips" and not "mipsel".
The warning is added in 1.80.0, but can be disabled by updating the
Cargo.toml file.
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks

@Dirbaio Dirbaio added this pull request to the merge queue Aug 5, 2024
Merged via the queue into smoltcp-rs:main with commit 2d4dde7 Aug 5, 2024
12 checks passed
@thvdveld thvdveld deleted the fix-cfgs branch August 5, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants