Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smooks-edi-cartridge 2.0.0-RC1 UTF-8 symbols #224

Closed
muellerch2293 opened this issue Apr 11, 2023 · 5 comments · Fixed by smooks/smooks-dfdl-cartridge#150 or #245
Closed

smooks-edi-cartridge 2.0.0-RC1 UTF-8 symbols #224

muellerch2293 opened this issue Apr 11, 2023 · 5 comments · Fixed by smooks/smooks-dfdl-cartridge#150 or #245
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@muellerch2293
Copy link

Hi,
Smooks is just great! Thanks for that!
i am referring to the post in:
https://groups.google.com/g/smooks-user/c/fkEp8TDJKxY/m/XBgDoz4uBgAJ
we are experiencing the same issue. Can you try to make the encoding parametrizable?
Regards Christian

@muellerch2293
Copy link
Author

to our understanding it would be best if the encoding was automatically detected using the payload UNOY UNOC etc...
what do you think about that?

@muellerch2293
Copy link
Author

Hi, pushing this issue again...
i think that this issue is essential for all non-US users.
it would be great if you could look into it!
Regards Christian

@cjmamo
Copy link
Member

cjmamo commented May 5, 2023

Hi Christian, have you tried the solution that was posted in the thread?

This problem is likely happening because IBM_EDI_Format.dfdl.xsd has its encoding hard-coded to iso-8859-1. An easy workaround is to modify edi-to-xml-order-mapping.dfdl.xsd so that it points to your own DFDL format which has the encoding set to utf-8. It would be great if you could open an issue for this. The encoding can probably be parameterised.

At first glance I'd say automatically detecting the encoding isn't trivial to correctly implement.

@cjmamo cjmamo self-assigned this May 5, 2023
@cjmamo
Copy link
Member

cjmamo commented Jun 4, 2023

Can we close this one @muellerch2293?

cjmamo added a commit to cjmamo/smooks-dfdl-cartridge that referenced this issue Sep 3, 2023
… the content-encoding can be set in the EDI cartridge in order to fix smooks/smooks-edi-cartridge#224
cjmamo added a commit to cjmamo/smooks-dfdl-cartridge that referenced this issue Sep 3, 2023
… the content-encoding can be set in the EDIFACT cartridge and fix smooks/smooks-edi-cartridge#224
@cjmamo cjmamo added this to the v2.0.0-RC3 milestone Sep 3, 2023
@cjmamo cjmamo added the type: bug Something isn't working label Sep 3, 2023
cjmamo added a commit to cjmamo/smooks-dfdl-cartridge that referenced this issue Sep 3, 2023
@cjmamo cjmamo reopened this Sep 3, 2023
cjmamo added a commit to cjmamo/smooks-edi-cartridge that referenced this issue Sep 3, 2023
…the DFDL schema and setting it from the execution context with org.smooks.api.ExecutionContext#setContentEncoding
@cjmamo cjmamo reopened this Sep 3, 2023
cjmamo added a commit that referenced this issue Sep 3, 2023
…ema and setting it from the execution context with org.smooks.api.ExecutionContext#setContentEncoding (#245)
@cjmamo
Copy link
Member

cjmamo commented Sep 3, 2023

The encoding has been parameterised and it can be set from the Smooks execution context: executionContext.setContentEncoding("UTF-8")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment