Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

Make modals accessible #31

Closed
gregberge opened this issue Sep 8, 2018 · 0 comments
Closed

Make modals accessible #31

gregberge opened this issue Sep 8, 2018 · 0 comments
Labels
A11Y ♿️ Acessibility enhancement ✨

Comments

@gregberge
Copy link
Member

Actually modals are not accessible for severals reasons (see #25 and #26).

Reach UI makes a good work on a11y exploration, see https://ui.reach.tech/dialog.
gregberge added a commit that referenced this issue Oct 18, 2018
@gregberge
feat: make modals accessible
adcb3ea 
Closes #31
Closes #26
Closes #25

BREAKING CHANGE:

"persistent" prop has been removed from Modal, Modal are now
non-persistent.

"sui-modal-backdrop" has been removed, it is now "sui-modal".
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A11Y ♿️ Acessibility enhancement ✨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregberge