-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence ggplot2 3.4.0 deprecation warnings. #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks moving away from aes sring will be another beast I tried to apply the recommended programming with !! sym etc. i the new functions thanks again for all the edits
But nowadays, there is something simpler that would allow users to provide input as Non-standard eval and quoted using the It simplifies a lot how the input can be used by dplyr and ggplot2. I can try a proof of concept maybe after the next CRAN release to ensure that changes are digestable and don't cause unexpected breakages. |
yes I have started a CRAN submission earlier today I will wait for this PR as I think I need to rework the UI and Server of the main shiny app more to make sure I define a linewidth aesthetic that is applied when applicable as opposed to the size one now applied on both lines and points |
Sure thing. But the main goal is just that everything should work as expected, for example As explained in the blog post I shared, the only problematic case may be Happy to help and to answer any questions you may have Cheers! |
But in the shiny server you have |
ok got it, I will open another issue after merging to add a global linewidth aesthetic input and then use it when appropriate in the app but that will require ton of effort density and km in the app do not use the global size aesthetic mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In news maybe state that the |
Addresses #27
I followed advice here:
https://www.tidyverse.org/blog/2022/08/ggplot2-3-4-0-size-to-linewidth/#the-fix
There are still some warnings about
aes_string()
, but that would require more work, as I think it would require updating to the latest standards of NS evaluation everywhere, in dplyr and ggplot2 code for consistency. Links for this: https://ggplot2.tidyverse.org/dev/articles/ggplot2-in-packages.html and https://dplyr.tidyverse.org/articles/programming.htmlWarnings in https://smouksassi.github.io/ggquickeda/reference/geom_km.html will be silenced.