Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skeleton for multitarget #2

Closed
wants to merge 15 commits into from
Closed

skeleton for multitarget #2

wants to merge 15 commits into from

Conversation

smparkes
Copy link
Owner

This is a follow-on to the configuration PR. It shows the basic idea of using a macro shim to create multiple targets based on the configuration.

It's not correct yet: it doesn't handle the different versions correctly. What it does do is include documentation on the approach to give folks a chance to comment on.

I'll work on flushing out the implementation but would welcome thoughts on the approach.

@smparkes
Copy link
Owner Author

Works for the current example builds. It should be creating and running parallel subgraphs for each version.
The code could use cleanup but isn't horrible. I'll do more cleanup passes as things progress.
For now I want to move on to actually creating and using correct toolchains (everything right now says it's using alternate toolchains but they're all configured with the default toolchain params.)

@smparkes smparkes marked this pull request as ready for review January 30, 2020 02:33
@smparkes
Copy link
Owner Author

Moving this to a PR on upstream.

@smparkes smparkes closed this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant