Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): update phpstan/phpstan requirement from 1.10.18 to 1.10.33 #1679

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2023

Updates the requirements on phpstan/phpstan to permit the latest version.

Release notes

Sourced from phpstan/phpstan's releases.

1.10.33

Improvements 🔧

Bugfixes 🐛

Function signature fixes 🤖

  • More precise inotify related function signatures (#2599), thanks @​thg2k!

Internals 🔍

  • Prevent most $parentPhpDocBlock->getClassReflection()->isBuiltin() calls (#2585), thanks @​staabm!
  • micro: use spl_object_id() (#2592), thanks @​staabm!
  • Update nette/di (#2597)
Commits
  • 03b1cf9 PHPStan 1.10.33
  • dfcaa30 Updated PHPStan to commit dfcaa3082c975b13847ff9de5e55438ce7b65fc4
  • 1e02121 Updated PHPStan to commit 1e021211cdc8373716dc4b59f3e2de35feba06d7
  • 0d3dc89 Updated PHPStan to commit 0d3dc89e2fda137c664b9be3a2c0391549dc0c1d
  • 3e03e9d Updated PHPStan to commit 3e03e9d7c15fdf64e6d55539a6c3045b3b8c6604
  • d44ae55 Updated PHPStan to commit d44ae5545a611087c6a23db4bca53146da5d163a
  • 9f93828 Updated PHPStan to commit 9f93828bac0b145a5b92c56f6dac2c76fb043892
  • 5a2e13c Updated PHPStan to commit 5a2e13ca15f704f78bd5961984060d70ac6bfe79
  • bdb141d Updated PHPStan to commit bdb141dc731bb6f84c55dba2732cef6be718e4a3
  • 304d67e Updated PHPStan to commit 304d67eed6a6a60c7f12b3f2c2baa728b5ebf7c2
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Sep 4, 2023
@hemberger
Copy link
Member

@dependabot rebase

Updates the requirements on [phpstan/phpstan](https://github.com/phpstan/phpstan) to permit the latest version.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md)
- [Commits](phpstan/phpstan@1.10.18...1.10.33)

---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/composer/phpstan/phpstan-1.10.33 branch from a7dbb2b to 4049c50 Compare September 9, 2023 21:43
Previously, we would allow creating an `SmrAlliance` instance when the
input `$allianceID` was 0. This was problematic because most of the
class attributes would be unset, and most methods would be unusable.

Now, we will raise an AllianceNotFoundError if the ID is 0, and we
remove the `isNone` method. This will ensure that all instances of the
class are valid and can be used without restriction. We replace the
existing `isNone` calls with checks if the alliance ID is 0.
Always initialize the `TotalDamagePerTargetPlayer` field of the
`TraderCombatResult` array type. This fixes a PHPStan warning.
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.03% ⚠️

Comparison is base (8c20c57) 30.81% compared to head (0d7e33e) 30.79%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1679      +/-   ##
============================================
- Coverage     30.81%   30.79%   -0.03%     
+ Complexity     4021     4019       -2     
============================================
  Files           122      122              
  Lines         12781    12783       +2     
============================================
- Hits           3939     3936       -3     
- Misses         8842     8847       +5     
Files Changed Coverage Δ
src/lib/Smr/AbstractShip.php 31.58% <0.00%> (-0.29%) ⬇️
src/lib/Smr/Alliance.php 30.37% <100.00%> (-0.53%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hemberger hemberger merged commit f5bb2ce into main Sep 9, 2023
7 of 8 checks passed
@hemberger hemberger deleted the dependabot/composer/phpstan/phpstan-1.10.33 branch September 9, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant