Miscellaneous fixes #1934
Merged
Miscellaneous fixes #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Players were (reasonably) expecting their SMR credits to be processed automatically, and were confused when they were not showing up. This note at least notifies them that there will be a delay.
The `bounty.amount` column is an UNSIGNED INT in the database, and so we need to prevent the value from increasing to beyond its maximum value. Otherwise, we get a "value out of range" SQL error.
The `message_boxes.message_text` column is type TEXT, which has a limit on the string length. When logging exceptions, make sure we restrict the length of the message to this limit to avoid a database error.
This fixes libxml errors when the thread topic includes, e.g., an ampersand.
The `account_has_ip.host` column is a varchar(64). Truncate the host if it is too long to avoid a database error. The full host name is not particularly important.
The `planet.password` and `planet.planet_name` columns are varchar(32), so use HTML5 to restrict the user to 32 characters to avoid a database error.
Use HTML5 to restrict the fontsize input to its (arbitrary) minimum value and its (database-driven) maximum value. The type of the `account.fontsize` column is UNSIGNED TINYINT.
Use HTML5 to prevent users from entering in an alliance name/description that will result in a database error.
The `bar_tender.message` column is a VARCHAR(255), so limit the message length to 255 to avoid a database error.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
=========================================
Coverage 31.48% 31.49%
- Complexity 4202 4203 +1
=========================================
Files 125 125
Lines 12718 12718
=========================================
+ Hits 4004 4005 +1
+ Misses 8714 8713 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
htmlentities.