Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this compatible with Node 4.1+? #13

Closed
darshit-shah opened this issue Nov 9, 2015 · 8 comments
Closed

Is this compatible with Node 4.1+? #13

darshit-shah opened this issue Nov 9, 2015 · 8 comments

Comments

@darshit-shah
Copy link

I upgrade my node version from 0.8.17 to 4.1 and now lo_solve stopped working.
I tried to do fresh npm install but still failed.
Do I suppose to do any other step?

@smremde
Copy link
Owner

smremde commented Nov 9, 2015

I haven't tried Node 4.1. What is the error?

@darshit-shah
Copy link
Author

d:{{some_folder}}\node_modules\lp_solve\node_modules\bindings\bindings.
js:83
throw e
^
Error: The specified procedure could not be found.
d:{{some_folder}}\node_modules\lp_solve\build\Release\lp_solve.node
at Object.Module._extensions..node (module.js:485:11)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:362:17)
at require (module.js:378:17)
at bindings (d:{{some_folder}}\node_modules\lp_solve\node_modules\b
indings\bindings.js:76:44)
at Object. (d:{{some_folder}}\node_modules\lp_solve\inde
x.js:4:35)
at Module._compile (module.js:449:26)
at Object.Module._extensions..js (module.js:467:10)
at Module.load (module.js:356:32)

@smremde
Copy link
Owner

smremde commented Nov 10, 2015

No error when you install the pakage?

@darshit-shah
Copy link
Author

No

On Tue, Nov 10, 2015 at 3:00 PM, Stephen Remde notifications@github.com
wrote:

No error when you install the pakage?


Reply to this email directly or view it on GitHub
#13 (comment)
.

@smremde
Copy link
Owner

smremde commented Nov 10, 2015

Yes there is. I just tested.

It is related to this issue:

nodejs/node#2798

I don't intend on fixing this as a priority, it require migrating to NAN2. There are some scripts to migrate code automatically which I might give a quick try.

@darshit-shah
Copy link
Author

Thank you.

-----Original Message-----
From: "Stephen Remde" notifications@github.com
Sent: ‎10-‎11-‎2015 15:11
To: "smremde/node-lp_solve" node-lp_solve@noreply.github.com
Cc: "Darshit Shah" darshit@yuktianalytics.com
Subject: Re: [node-lp_solve] Is this compatible with Node 4.1+? (#13)

Yes there is. I just tested.
It is related to this issue:
nodejs/node#2798
I don't intend on fixing this as a priority, it require migrating to NAN2. There are some scripts to migrate code automatically which I might give a quick try.

Reply to this email directly or view it on GitHub.

@MrOrz
Copy link

MrOrz commented Jun 10, 2016

I can install node-lp_solve using node 4.4.5 with no issue.

However, the installation fails on node 6.2.1.

Seems that node_modules/nan/nan.h:590:20 is the cause?

> lp_solve@0.2.12 install /Users/mrorz/workspace/gis-inner/node_modules/lp_solve
> node-gyp rebuild

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
  CC(target) Release/obj.target/lp_solve_5.5/deps/lp_solve/lp_solve_5.5/lp_MDO.o
  CC(target) Release/obj.target/lp_solve_5.5/deps/lp_solve/lp_solve_5.5/shared/commonlib.o

  -- (irrelevant warnings omitted) --

  CC(target) Release/obj.target/lp_solve_5.5/deps/lp_solve/lp_solve_5.5/yacc_read.o
  LIBTOOL-STATIC Release/lp_solve_5.5.a
  CXX(target) Release/obj.target/lp_solve/lp_solve.o
In file included from ../lp_solve.cc:2:
../node_modules/nan/nan.h:590:20: error: no type named 'GCEpilogueCallback' in 'v8::Isolate'
      v8::Isolate::GCEpilogueCallback callback
      ~~~~~~~~~~~~~^
../node_modules/nan/nan.h:596:20: error: no type named 'GCEpilogueCallback' in 'v8::Isolate'
      v8::Isolate::GCEpilogueCallback callback) {
      ~~~~~~~~~~~~~^
../node_modules/nan/nan.h:601:20: error: no type named 'GCPrologueCallback' in 'v8::Isolate'
      v8::Isolate::GCPrologueCallback callback
      ~~~~~~~~~~~~~^
../node_modules/nan/nan.h:607:20: error: no type named 'GCPrologueCallback' in 'v8::Isolate'
      v8::Isolate::GCPrologueCallback callback) {
      ~~~~~~~~~~~~~^
../lp_solve.cc:352:7: warning: unused variable 'res' [-Wunused-variable]
                int res = solve(lp);
                    ^
../lp_solve.cc:2807:2: warning: 'delete' applied to a pointer that was allocated with 'new[]'; did you
      mean 'delete[]'? [-Wmismatched-new-delete]
        delete var;
        ^
              []
../lp_solve.cc:2803:14: note: allocated with 'new[]' here
        REAL* var = new REAL[var_n];
                    ^
2 warnings and 4 errors generated.
make: *** [Release/obj.target/lp_solve/lp_solve.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/mrorz/.nvm/versions/node/v6.2.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)
gyp ERR! System Darwin 15.4.0
gyp ERR! command "/Users/mrorz/.nvm/versions/node/v6.2.1/bin/node" "/Users/mrorz/.nvm/versions/node/v6.2.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/mrorz/workspace/gis-inner/node_modules/lp_solve
gyp ERR! node -v v6.2.1
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok

@smremde
Copy link
Owner

smremde commented Dec 19, 2018

Closing this nan has been updated.

If it's still a problem, reopen. I'm using version 8.9.4 no problem.

@smremde smremde closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants