Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we do need a notion of newline after all #28

Closed
mengwong opened this issue Oct 12, 2021 · 4 comments
Closed

we do need a notion of newline after all #28

mengwong opened this issue Oct 12, 2021 · 4 comments

Comments

@mengwong
Copy link
Contributor

an action might look like

-> pay
to = bob, alice
amount = 100 each

@mengwong
Copy link
Contributor Author

proposal: in the preprocessor, add an EOL token, concretely ;

@anka-213
Copy link
Contributor

(This won't be closed automatically until you merge the branch into master)

@anka-213
Copy link
Contributor

Please don't do huge squash commits with huge messages like that. It removes all sense of history, so you can't hover over a line to figure out why it was added.

Also, the git lens plugin for VS Code tries to show the whole commit message before you can see the type on hovering, but I guess that's the plugin's fault.

@anka-213
Copy link
Contributor

At least add a summary to the top, so we don't have to read the whole thing to figure out what it's about, otherwise the squashing provides zero value. Use rebase if you want to remove merge commits, and use git rebase -i if you want to merge tiny "fixup" commits into a single one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants