Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add sound when done Computing issues #863

Closed
sbrevolution5 opened this issue Apr 9, 2024 · 6 comments
Closed

[FEATURE REQUEST] Add sound when done Computing issues #863

sbrevolution5 opened this issue Apr 9, 2024 · 6 comments
Assignees
Labels
delayed Need to wait for something else to workout on this enhancement New feature or request

Comments

@sbrevolution5
Copy link

Is your feature request related to a problem?

It can take a long time to run the issue computation/fix, utility, and I usually go and do something else while its running.

Describe the solution you'd like

It would be very convenient if we could have the option to have a chime or ding of some sort play when the issues are finished being detected and fixed. I understand this is such a small concern, but its a potential improvement.

Files

No response

@sbrevolution5 sbrevolution5 added the enhancement New feature or request label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

This is your first time submitting an issue with UVtools 🥳Please review your issue and ensure that the submit template was followed, the information is complete, and not related to any other open issue. It will be reviewed shortly. Debugging is very important and make the program better. Thanks for contributing and making the software better! 🙌

@sn4k3
Copy link
Owner

sn4k3 commented Apr 9, 2024

Cross platform audio engine are heavy and add some dependencies, just to support this is a bit of non-sense.
However if it help I can add native notifications, that itself produce a sound from OS if not muted.

Are you on Windows?

@sbrevolution5
Copy link
Author

sbrevolution5 commented Apr 10, 2024 via email

@sn4k3 sn4k3 added the delayed Need to wait for something else to workout on this label Apr 11, 2024
@sn4k3
Copy link
Owner

sn4k3 commented Apr 11, 2024

This have to be delayed. Using notifications requires at least Windows 10, version 1809 TFM which will exclude Windows 7 from working with UVtools, I'm not interested in keep two separate builds for windows.
Drop the support for Windows 7 is expected when transiting to net8.0 in next major of UVtools (v5).

The solution I came with now is using a spawn of process to write and show the notification, but will only work under windows 10+. That will also allow to produce a beep.

@sn4k3
Copy link
Owner

sn4k3 commented Apr 13, 2024

I come to this:

image

Works under Windows & Linux. For mac it will play system invalid beep (No frequency nor duration able)

sn4k3 added a commit that referenced this issue Apr 19, 2024
- **Tool - Change resolution:**
  - (Add) 12K resolution profile
  - (Improvement) Do not mark the option "Resize layers with the proposed ratio" when a machine preset results in the same pixel size / ratio of (1.0x, 1.0x)
  - (Fix) Wait time before cure suggestion for GOO and PRZ file formats, it now allows the use of the create first empty layer (#864)
- **Thumbnail sanitizer:**
  - (Add) Check if the thumbnails have the correct number of channels, if not it will throw an error
  - (Improvement) When full encode a file, strip all extra thumbnails that are not used by the file format if they are not an archive
  - (Improvement) Resize all thumbnails to the same size as the original from file format even when there are more than file format requires, this fixes a problem when converting from zip that have many thumbnails but file format selects the larger and the smallest, leading to encode the wrong size
  - (Improvement) Convert thumbnails to BGR and strip the alpha channel when required, this fixes the issue where format conversion from zip such as sl1 and vdt where corrupting the final file with invalid thumbnail rle
- (Add) Tool - Light bleed compensation: Add "Dim subject" option to select from different subjects to dim, "Bridges" was added (#868)
- (Add) Settings - Notifications: Allow to define beeps sounds to play after ran long operations (#863)
- (Improvement) CTB, FDG, PHZ: Make possible to encode a thumbnail using 1 and 4 channels, this fixes the issue where the file format could encode invalid thumbnail data
- (Improvement) Add empty layer for Goo file format when running the wait time before cure suggestion
- (Fix) Terminal: The run globals was lost from the previous version update
- (Upgrade) .NET from 6.0.28 to 6.0.29
@sn4k3
Copy link
Owner

sn4k3 commented Apr 19, 2024

Implemented

@sn4k3 sn4k3 closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delayed Need to wait for something else to workout on this enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants