Tracing JIT stability improvements from lwAFTR #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We reset all hotcounts every second. This is a rough way to establish a relation with elapsed time so that hotcounts provide a measure of frequency. The concrete goal is to ensure that the JIT will trace code that becomes hot over a short duration, but not code that becomes hot over, say, the course of an hour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some improvements to ingress_drop_monitor as well as an experimental patch[1] for RaptorJIT that prevents “long-tail trace” generation.
I’ve decided to include this since it has worked well for lwAFTR and I think is ready for broader application in Snabb upstream.