Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #260

Merged
merged 3 commits into from
Sep 16, 2014
Merged

Fixes #260

merged 3 commits into from
Sep 16, 2014

Commits on Sep 13, 2014

  1. lib.pcap: Fix memory corruption bug affecting unit tests 

    The bug could cause occasional segmentation faults in code that uses
the pcap reader library, such as the ipv6 and packet filter unit tests.

The bug is that ffi.copy() writes one by more than we want. See caveat
mentioned in the LuaJIT docs at http://luajit.org/ext_ffi_api.html:

    ffi.copy(dst, src):
    All bytes of the string plus a zero-terminator are copied to
    dst (i.e. #src+1 bytes).

Amusingly, this bug was introduced by the previous change (commit
8def591) that simultaneously fixed a different more-or-less
equivalent bug in the same function.
    @lukego
    lukego committed Sep 13, 2014
    Configuration menu
    Copy the full SHA
    bf48508 View commit details
    Browse the repository at this point in the history

  2. lib.pcap: Remove 'extra' nonstandard pcap format extension 

    This was an old hack to store additional metadata on pcap records. Wed
don't use it anymore.
    @lukego
    lukego committed Sep 13, 2014
    Configuration menu
    Copy the full SHA
    23723b4 View commit details
    Browse the repository at this point in the history

  3. pci.lua: Scan devices in selftest() and remove dead code

    @lukego
    lukego committed Sep 13, 2014
    Configuration menu
    Copy the full SHA
    078760c View commit details
    Browse the repository at this point in the history