Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make specification of SRA samples in samples.tsv work (common.smk) #63

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

dlaehnemann
Copy link
Contributor

Previously, u was restricted to columns ["fq1", "fq2"] and any found entry dropped altogether if both entries are NA. Now, this simply selects one entry in samples.tsv and all the necessary columns should still be there for proper handling in the following lines.

closes #52

Copy link

@FelixMoelder FelixMoelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears reasonable to me :)

@dlaehnemann dlaehnemann merged commit 5f88554 into master Apr 13, 2023
@dlaehnemann dlaehnemann deleted the fix-sra-handling branch April 13, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem when defining SRA accession instead of fq1/fq2 hardfiles
2 participants